Repository navigation
issue #591: move herddb.index.vector storage classes to herddb-indexing-service - #593
Merged
eolivelli merged 1 commit intoMay 19, 2026
Merged
Conversation
…ng-service Move 18 production classes (AbstractVectorStore, PersistentVectorStore, ReadOnlyVectorStore, VectorIndexCompactor, VectorSegment, NewSegmentInfo, PagedPkSet, CompactionAuthorityMap, SegmentPublisher, GraphWriterFactory, RemoteSegmentGraphMerger, VectorMemoryBudget, VectorStorage, VectorStorageRandomAccessVectorValues, ChannelFileBackedVectorValues, FileBackedVectorValues, MmapFileBackedVectorValues, SegmentedMappedReader) from herddb-core to herddb-indexing-service under the new package herddb.indexing.vector. Move 58 companion test files from herddb-core to herddb-indexing-service. Keep VectorIndexManager, RemoteVectorIndexService, and PinModeReaderSupplier in herddb-core (used by TableSpaceManager, DBManager, and RemoteRandomAccessReader respectively). Add io.github.jbellis:jvector as a direct dependency of herddb-indexing-service. Fix PinModeReaderSupplier import in herddb-remote-file-service (class stays in herddb-core but its formerly same-package test reference needs an explicit import in herddb-indexing-service). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #591.
Changes
herddb-core — classes removed
AbstractVectorStore,PersistentVectorStore,ReadOnlyVectorStore,VectorIndexCompactor,VectorSegment,NewSegmentInfo,PagedPkSet,CompactionAuthorityMap,SegmentPublisher,GraphWriterFactory,RemoteSegmentGraphMerger,VectorMemoryBudget,VectorStorage,VectorStorageRandomAccessVectorValues,ChannelFileBackedVectorValues,FileBackedVectorValues,MmapFileBackedVectorValues,SegmentedMappedReader) fromherddb.index.vectorherddb-core:VectorIndexManager(instantiated byTableSpaceManager),RemoteVectorIndexService(SPI interface used byDBManager), andPinModeReaderSupplier(used byherddb-remote-file-servicewhich cannot depend onherddb-indexing-service)herddb-indexing-serviceherddb-indexing-service — classes added
herddb.indexing.vectorwith the 18 moved production classes (package rename fromherddb.index.vector→herddb.indexing.vector)src/test/java/herddb/indexing/vector/io.github.jbellis:jvectoras a direct dependency (pom.xml)IndexingServiceEngine,VectorIndexRebuilder,InMemoryVectorStore,VectorStoreFactory,optimizer/*,segment/*, and all test classes)herddb-remote-file-service — import updated
RemoteRandomAccessReader+RemoteRandomAccessReaderPinModeTest: updatedimport herddb.index.vector.PinModeReaderSupplierto use explicit package (class stays inherddb-corebut was previously accessed via same-package from a file now in a different package)Tests
install -DskipTests -Pci) passed for all 22 modulesVectorIndexRetentionTest,PersistentVectorStoreCapComputationTest,PersistentVectorStoreBackoffTest,PersistentVectorStoreSupportsVectorIndexesTest,VectorIndexCompactorChooseTest,CompactionAuthorityMapBLinkTest(inherddb-indexing-service)herddb-core:VectorIndexManagerRebuildLsnCodecTest,VectorIndexManagerDropNotifiesRemoteServiceTest,VectorIndexManagerSearchStreamTest🤖 Implemented by the
pr-workeragent.